From f0d2f07703d167259dc5183bd319e34c0b42a47a Mon Sep 17 00:00:00 2001
From: alexcrea <contact@alexcrea.xyz>
Date: Mon, 23 Mar 2026 20:06:58 +0100
Subject: [PATCH] int item display better

---
 .../config/global/EnchantLimitConfigGui.java  | 14 ++++-
 .../gui/config/settings/IntSettingsGui.java   | 59 +++++++++++--------
 2 files changed, 45 insertions(+), 28 deletions(-)

diff --git a/src/main/java/xyz/alexcrea/cuanvil/gui/config/global/EnchantLimitConfigGui.java b/src/main/java/xyz/alexcrea/cuanvil/gui/config/global/EnchantLimitConfigGui.java
index a95a5bb..e9edbeb 100644
--- a/src/main/java/xyz/alexcrea/cuanvil/gui/config/global/EnchantLimitConfigGui.java
+++ b/src/main/java/xyz/alexcrea/cuanvil/gui/config/global/EnchantLimitConfigGui.java
@@ -58,9 +58,17 @@ public class EnchantLimitConfigGui extends AbstractEnchantConfigGui<IntSettingsG
             }
 
             @Override
-            public String valueDisplayName(int value) {
-                if(value == -1) return "Default (" + defaultValue + ")";
-                return super.valueDisplayName(value);
+            public String valueDisplayName(IntSettingsGui.ValueDisplayType type, int value) {
+
+                if(value < 0) {
+                    return switch (type) {
+                        case CURRENT -> "Default (" + defaultValue + ")";
+                        case RESET -> String.valueOf(defaultValue);
+                        default -> "Default";
+                    };
+
+                }
+                else return super.valueDisplayName(type, value);
             }
         };
     }
diff --git a/src/main/java/xyz/alexcrea/cuanvil/gui/config/settings/IntSettingsGui.java b/src/main/java/xyz/alexcrea/cuanvil/gui/config/settings/IntSettingsGui.java
index 5a713cf..f2ce0c1 100644
--- a/src/main/java/xyz/alexcrea/cuanvil/gui/config/settings/IntSettingsGui.java
+++ b/src/main/java/xyz/alexcrea/cuanvil/gui/config/settings/IntSettingsGui.java
@@ -72,7 +72,8 @@ public class IntSettingsGui extends AbstractSettingGui {
         assert meta != null;
 
         meta.setDisplayName("§eReset to default value");
-        meta.setLore(Collections.singletonList("§7Default value is §e" + holder.defaultVal));
+        meta.setLore(Collections.singletonList("§7Default value is §e" +
+                holder.valueDisplayName(ValueDisplayType.RESET, holder.defaultVal)));
         item.setItemMeta(meta);
         returnToDefault = new GuiItem(item, event -> {
             event.setCancelled(true);
@@ -86,42 +87,23 @@ public class IntSettingsGui extends AbstractSettingGui {
      * Update item using the setting value to match the new value.
      */
     protected void updateValueDisplay() {
-
         PatternPane pane = getPane();
-        var displayNow = holder.valueDisplayName(now);
 
         // minus item
         GuiItem minusItem;
         if (now > holder.min) {
-            int planned = Math.max(holder.min, now - step);
-            ItemStack item = new ItemStack(Material.RED_TERRACOTTA);
-            ItemMeta meta = item.getItemMeta();
-            assert meta != null;
-
-            meta.setDisplayName("§e" + displayNow + " §f-> §e" + planned + " §r(§c-" + holder.valueDisplayName(now - planned) + "§r)");
-            meta.setLore(Collections.singletonList(AbstractSettingGui.CLICK_LORE));
-            item.setItemMeta(meta);
-
-            minusItem = new GuiItem(item, updateNowConsumer(planned), CustomAnvil.instance);
+            int planned = Math.min(holder.max, now + step);
+            minusItem = valueEditItem(Material.RED_TERRACOTTA, ValueDisplayType.REMOVE, planned);
         } else {
             minusItem = GuiGlobalItems.backgroundItem(Material.BARRIER);
         }
         pane.bindItem('-', minusItem);
 
         //plus item
-        // may do a function to generalise ?
         GuiItem plusItem;
         if (now < holder.max) {
             int planned = Math.min(holder.max, now + step);
-            ItemStack item = new ItemStack(Material.GREEN_TERRACOTTA);
-            ItemMeta meta = item.getItemMeta();
-            assert meta != null;
-
-            meta.setDisplayName("§e" + displayNow + " §f-> §e" + planned + " §r(§a+" + holder.valueDisplayName(planned - now) + "§r)");
-            meta.setLore(Collections.singletonList(AbstractSettingGui.CLICK_LORE));
-            item.setItemMeta(meta);
-
-            plusItem = new GuiItem(item, updateNowConsumer(planned), CustomAnvil.instance);
+            plusItem = valueEditItem(Material.GREEN_TERRACOTTA, ValueDisplayType.ADD, planned);
         } else {
             plusItem = GuiGlobalItems.backgroundItem(Material.BARRIER);
         }
@@ -132,7 +114,7 @@ public class IntSettingsGui extends AbstractSettingGui {
         ItemMeta resultMeta = resultPaper.getItemMeta();
         assert resultMeta != null;
 
-        resultMeta.setDisplayName("§fValue: §e" + displayNow);
+        resultMeta.setDisplayName("§fValue: §e" + holder.valueDisplayName(ValueDisplayType.CURRENT, now));
         resultMeta.setLore(holder.displayLore);
 
         resultPaper.setItemMeta(resultMeta);
@@ -150,7 +132,21 @@ public class IntSettingsGui extends AbstractSettingGui {
         }
         pane.bindItem('D', returnToDefault);
 
+    }
 
+    private GuiItem valueEditItem(Material mat, ValueDisplayType type, int planned) {
+        ItemStack item = new ItemStack(mat);
+        ItemMeta meta = item.getItemMeta();
+        assert meta != null;
+
+        var nowDisplay = holder.valueDisplayName(type, now);
+        var plannedDisplay = holder.valueDisplayName(type, planned);
+        var deltaDisplay = holder.deltaDisplay(type, now, planned);
+        meta.setDisplayName("§e" + nowDisplay + " §f-> §e" + plannedDisplay + " §r(§c" + deltaDisplay + "§r)");
+
+        meta.setLore(Collections.singletonList(AbstractSettingGui.CLICK_LORE));
+        item.setItemMeta(meta);
+        return new GuiItem(item, updateNowConsumer(planned), CustomAnvil.instance);
     }
 
     /**
@@ -390,10 +386,23 @@ public class IntSettingsGui extends AbstractSettingGui {
             return getItem(itemMat, CasedStringUtil.detectToUpperSpacedCase(configPath));
         }
 
-        public String valueDisplayName(int value) {
+        protected String valueDisplayName(ValueDisplayType type, int value) {
             return String.valueOf(value);
         }
 
+        protected String deltaDisplay(ValueDisplayType type, int now, int planned) {
+            var delta = planned - now;
+            if(delta < 0) return "§c" + delta;
+            else return "§a+" + delta;
+        }
+
+    }
+
+    public enum ValueDisplayType {
+        ADD,
+        CURRENT,
+        REMOVE,
+        RESET,
     }
 
 }